-
Notifications
You must be signed in to change notification settings - Fork 743
Boundary events scheduling and jumping updates #9764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Boundary events scheduling and jumping updates #9764
Conversation
@@ -60,6 +60,10 @@ To add a boundary event to the [above-listed activities](#supported-activities), | |||
|
|||
To configure the properties of a boundary event, double-click the event to open its properties dialog box. For more information on how to configure the properties of a timer boundary event, see [Boundary Properties](/refguide/timer/#boundary-properties). | |||
|
|||
#### Adding a Boundary Event to an Ongoing Activity | |||
|
|||
When a boundary event is added to an ongoing activity, any workflow instances currently executing that activity will schedule the new boundary event accordingly. The only exception occurs when an ongoing boundary event is removed, the workflow is redeployed, and then the removal is reverted. In this case, the boundary event will not be rescheduled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use the following version but I am not sure if my understanding is correct. So I am writting my suggested version here and I've marked my changes in bold. Please let me know what you think of it:
When a boundary event is added to an ongoing activity, any workflow instances currently executing that activity will schedule the new boundary event accordingly. The only exception occurs when an ongoing boundary event is removed from the ongoing activity, the workflow is redeployed, and then the removal is reverted. In this case, the new boundary event will not be scheduled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yiyun333 Your version is technically correct and I find it more clear. The point is that you can add a new boundary event by just adding it normally or though an undo of previously removed boundary event. In the latter case you are also adding a "new" boundary event, because firstly if was removed (it's not there) and then Undo adds it back (it is there). In that case, though, the "new" re-added boundary event will not be scheduled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DmytroKost Thanks a lot for the explanation! In this case, "re-added" is better than "new" actually and I'll use "re-added" instead. See commit 2ed08fb.
For 11.1.0